Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds webhook format check for Slack #814

Merged
merged 30 commits into from
Nov 20, 2023
Merged

Adds webhook format check for Slack #814

merged 30 commits into from
Nov 20, 2023

Commits on Nov 16, 2023

  1. Microsoft teams (opensearch-project#676) 

    * Added feature support for microsoft teams webhoo

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for microsoft teams webhook ,removed valid webhooks

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for Microsoft teams webhook

Signed-off-by: danielkyalo599 <[email protected]>

* Refactored feature support for  ms teams and added unit and integTest

Signed-off-by: danielkyalo599 <[email protected]>

* fix build in core

Signed-off-by: zhichao-aws <[email protected]>

* fix core-spi build

Signed-off-by: zhichao-aws <[email protected]>

* fix notifications main code

Signed-off-by: zhichao-aws <[email protected]>

* fix mappings, add IT

Signed-off-by: zhichao-aws <[email protected]>

* add auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* put load mapping to initialize step

Signed-off-by: zhichao-aws <[email protected]>

* add schema_version field

Signed-off-by: zhichao-aws <[email protected]>

* add integ test

Signed-off-by: zhichao-aws <[email protected]>

* adjust with auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* add bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* resolve  comments

Signed-off-by: zhichao-aws <[email protected]>

* add license header

Signed-off-by: zhichao-aws <[email protected]>

* fix microsoft teams sample url in IT to adapt url validation

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @zhichao-aws @dankyalo599 @Noir01
    2 people authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0ff5ba0 View commit details
    Browse the repository at this point in the history

  2. Add microsoft teams validation error message (opensearch-project#746) 

    * add validation failure message for Microsoft Teams

Signed-off-by: zhichao-aws <[email protected]>

* modify integtest

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @zhichao-aws @Noir01
    zhichao-aws authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fbad722 View commit details
    Browse the repository at this point in the history

  3. onboard system and hidden index (opensearch-project#742) 

    Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dc36ba6 View commit details
    Browse the repository at this point in the history

  4. Updates demo certs used in integ tests (opensearch-project#756) 

    Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @DarshitChanpura @Noir01
    DarshitChanpura authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    344a172 View commit details
    Browse the repository at this point in the history

  5. Add 2.10.0 release notes (opensearch-project#755) 

    * Add 2.10.0 release notes

Signed-off-by: Hailong Cui <[email protected]>

* update release notes

Signed-off-by: Hailong Cui <[email protected]>

* Update opensearch-notifications.release-notes-2.10.0.0.md

Signed-off-by: Hailong Cui <[email protected]>

* fix wrong PR number

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c1b9a46 View commit details
    Browse the repository at this point in the history

  6. bump bwc version to 2.11 (opensearch-project#763) 

    Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7dcca6e View commit details
    Browse the repository at this point in the history

  7. Add 2.11 release notes (opensearch-project#774) 

    Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @yuye-aws @Noir01
    yuye-aws authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    93aa732 View commit details
    Browse the repository at this point in the history

  8. Fix integration test failure by allowing direct access to system inde… 

    …x warning (opensearch-project#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @gaobinlong @Noir01
    gaobinlong authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2c3cef0 View commit details
    Browse the repository at this point in the history

  9. Re-enable detekt 

    Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e5452cd View commit details
    Browse the repository at this point in the history

  10. bump bwc version to 2.12 (opensearch-project#793) 

    Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ff446bc View commit details
    Browse the repository at this point in the history

  11. Update dependency org.json:json to v20231013 (opensearch-project#795) 

    Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @gaobinlong @Noir01
    gaobinlong authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ecac8ae View commit details
    Browse the repository at this point in the history

  12. Impove security plugin enabling check (opensearch-project#792) 

    Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    445c1e7 View commit details
    Browse the repository at this point in the history

  13. Add github workflow to auto bump bwc version (opensearch-project#799) 

    * Adding bump bwc version github workflow

Signed-off-by: Hailong Cui <[email protected]>

* revert app id

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Hailong-am @Noir01
    Hailong-am authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fd4872d View commit details
    Browse the repository at this point in the history

  14. Replace the TestMailServer to GreenMail server (opensearch-project#801) 

    * Add 2.11 release notes (opensearch-project#774)

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>

* Fix integration test failure by allowing direct access to system index warning (opensearch-project#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Replace the TestMailServer to GreenMail server

Signed-off-by: rdani <[email protected]>

* bump bwc version to 2.12 (opensearch-project#793)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Update dependency org.json:json to v20231013 (opensearch-project#795)

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Re-enable detekt (opensearch-project#796)

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Add assertion for retrieval of notification

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to suggested version

Signed-off-by: rdani <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @rachana-dani @yuye-aws
    @gaobinlong @rachana-sudhindradani @Hailong-am @Noir01
    6 people committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c00a781 View commit details
    Browse the repository at this point in the history

  15. Onboard prod jenkins docker image to github actions (opensearch-proje… 

    …ct#809)

* Onboard prod jenkins docker image to github actions

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @peterzhuamazon @Noir01
    peterzhuamazon authored and Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9342dfa View commit details
    Browse the repository at this point in the history

  16. Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (opensea… 

    …rch-project#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0be0e40 View commit details
    Browse the repository at this point in the history

  17. Added Slack webhook URL validation regex 

    Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ce88847 View commit details
    Browse the repository at this point in the history

  18. Replaced wrongly formatted dummy Slack URL with properly formatted du… 

    …mmy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f8a6c61 View commit details
    Browse the repository at this point in the history

  19. Replaced more wrongly formatted dummy Slack URL with properly formatt… 

    …ed dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    de78a74 View commit details
    Browse the repository at this point in the history

  20. Replaced even more wrongly formatted dummy Slack URL with properly fo… 

    …rmatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b4977cb View commit details
    Browse the repository at this point in the history

  21. Replace path of mock Slack URL with sample_slack_url 

    Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f606953 View commit details
    Browse the repository at this point in the history

  22. Remove slackId from domainIds 

    Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    bffe5d6 View commit details
    Browse the repository at this point in the history

  23. Replace wrongly formatted dummy Slack URL with properly formatted dum… 

    …my Slack URL

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b56f436 View commit details
    Browse the repository at this point in the history

  24. Merge branch 'main' into patch-2 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2f85ea8 View commit details
    Browse the repository at this point in the history

  25. Add tests for wrong Slack URLs 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fe1189d View commit details
    Browse the repository at this point in the history

  26. Add validation tests for Slack URL 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8c17f39 View commit details
    Browse the repository at this point in the history

  27. Format 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    45823a6 View commit details
    Browse the repository at this point in the history

  28. GovSlack apps can use the slack-gov.com domain 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    84c17ed View commit details
    Browse the repository at this point in the history

  29. Merge remote-tracking branch 'origin/patch-2' into patch-2

    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    875048f View commit details
    Browse the repository at this point in the history

  30. Add validation for gov-slack.com domain 

    Signed-off-by: Aniruddh <[email protected]>
    @Noir01
    Noir01 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    aa3b636 View commit details
    Browse the repository at this point in the history