Don't fail create workflow on already-consumed OpenSearch REST params #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
force-pushed
the
fix-consumed-params
branch
from
f146098 to
4f02acc
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
fix-consumed-params
branch
from
4f02acc to
2960af8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
============================================
+ Coverage 73.74% 73.83% +0.09%
Complexity 663 663
============================================
Files 79 79
Lines 3314 3314
Branches 263 263
============================================
+ Hits 2444 2447 +3
+ Misses 756 752 -4
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Feb 27, 2024
owaiskazi19
approved these changes
Feb 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#543) Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 37a2869) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Feb 28, 2024
…rch REST params (#544) Don't fail create workflow on already-consumed OpenSearch REST params (#543) (cherry picked from commit 37a2869) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some OpenSearch params are consumed before being passed to a plugin REST handler, such as pretty, format, error_trace, human, filter_path.
This PR fixes the logic in #525 to remove all previously-consumed parameters from the params list, so it will only fail in the same cases that the request would normally fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.