fix compilation error in 1.3 #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
AWSHurneyt
approved these changes
Dec 4, 2024
|
Security test failing since 1.3.19 version -> https://github.com/opensearch-project/alerting/actions/workflows/security-test-workflow.yml?query=branch%3A1.3 Need to check what's the issue but the change through this PR hasn't caused the failure |
sbcd90
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix the compile issue caused by commit in opensearch core opensearch-project/OpenSearch@2428278#diff-82a53ae6a34c3d0e45623b804d761e1fa077c2cea74c1110d92bc808b7d8c5d2
As per the commit convertToStringFilter filter now accepts two params -> https://github.com/opensearch-project/OpenSearch/blame/1.3/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/IncludeExclude.java#L625
Related Issues
#1697
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.