Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support IP field in star tree indexing #16641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Nov 14, 2024

Description

The changes include support for IP field as part of star tree index as part of dimensions specifically.

Related Issues

Resolves #16642

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Nov 14, 2024
Copy link
Contributor

❌ Gradle check result for 5ed38f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 217db78: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.05%. Comparing base (5817710) to head (7a81d2f).

Files with missing lines Patch % Lines
...site/composite912/Composite912DocValuesWriter.java 36.36% 4 Missing and 3 partials ⚠️
...rch/index/compositeindex/datacube/IpDimension.java 73.68% 5 Missing ⚠️
...ndex/compositeindex/datacube/OrdinalDimension.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16641      +/-   ##
============================================
- Coverage     72.06%   72.05%   -0.01%     
- Complexity    65189    65225      +36     
============================================
  Files          5318     5319       +1     
  Lines        303942   303976      +34     
  Branches      43975    43979       +4     
============================================
- Hits         219039   219036       -3     
- Misses        66915    67008      +93     
+ Partials      17988    17932      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 3edb512: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dbde796: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: bharath-techie <[email protected]>
Copy link
Contributor

❌ Gradle check result for bc2e847: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: bharath-techie <[email protected]>
Copy link
Contributor

❕ Gradle check result for 7a81d2f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for IP fields as part of star tree index mapping
2 participants