-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cicero-SCM-runner #16
Comments
yep perfect!
…On Wed, Sep 9, 2020 at 6:38 PM Marit Sandstad ***@***.***> wrote:
Hi,
Just to leave an issue that I will be attempting to make a
Cicero-SCM-runner. I guess the appropriate thing to do is to make my own
fork and the make a pull-request later. Sound ok?
best,
Marit
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUH5G3EL4GW27HR4RIH7F3SE45IZANCNFSM4RBRB6CQ>
.
|
Just a quick question; so when you run magicc you have executable binary somewhere that you run (I would need to do the same for cicero) and you set this as an environmental variable. I can't find exactly where that is set, or whether you ship with such an executable when people just install the runner (which maybe they can't really do yet, or they're expected to have the magicc executable from somewhere else). Sorry for the dumb question, I'm sure it would all be obvious for somebody else... |
At the moment it's all set with a Anyway, for now the simplest is if you add an extra variable into our Then, whenever you need it in your code, you can get the path to that executable using
.env file in this line (openscm-runner/src/openscm_runner/run.py Line 15 in a6df89f
import openscm_runner . Turns out this isn't a very smart way to do things, but @lewisjared and I haven't got around to fixing it yet and it should be good enough for now.
|
Ok, a couple of questions: As you will have noticed, I have not managed to get anything together in time. I also have quite a bit of work to do to put it together. Is it still meaningful to try to get it up? |
Also: Should the runs just go from 2015, or do I need to define historical data from somewhere? |
That's up to you and the Cicero team. It's the key to running the scenarios so without this piece, it won't be possible. Do you have some efforts already? You can make a PR then I can give you some tips maybe?
This is slightly tricky. At the moment both MAGICC and FaIR take missing emissions from the RCMIP data. If you make a PR I can give you a hand.
You need to be able to take input data which only starts in 2015. What you do thereafter is up to you. Both MAGICC and FaIR bolt on their own internally hard-coded historical emissions (which are the same as the RCMIP emissions) and do runs from 1750 onwards. |
I do have a start but it is still a bit immature for a PR, but then I will try to get it to run and do a PR (will still be plenty of things to rectify...) Taking historical from RCMIP sounds perfectly fine. However, for future other emissions like CFCs etc. I can also take them from RCMIP, but are they the same in all ssps? Otherwise do I need to do some matching? |
We’ve just used SSP245 in all cases. There are plans to do something
smarter, but that will happen elsewhere so for now just using SSP245 is
fine.
…On Fri, 18 Sep 2020 at 6:15 pm, Marit Sandstad ***@***.***> wrote:
I do have a start but it is still a bit immature for a PR, but then I will
try to get it to run and do a PR (will still be plenty of things to
rectify...)
Taking historical from RCMIP sounds perfectly fine.
However, for future other emissions like CFCs etc. I can also take them
from RCMIP, but are they the same in all ssps? Otherwise do I need to do
some matching?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUH5G2A74BRP6ERLBWLYWDSGMJLRANCNFSM4RBRB6CQ>
.
|
Ok, nice, at least relatively easy to adhere to |
So, I'm getting closer to something that resembles an actual adapter (or so I think anyway). There are quite a few moving parts in terms of files I have to use (previous input data, parameter sets etc. For now I'm making a subfolder with that stuff, hope that's an ok solution, otherwise I'd be happy to find a smarter solution). I am hopeful that I'll be able to put in an at least nearly functional pull-request this week. Is that a somewhat acceptable time frame? (I know this has been slow, but I don't think it really could have been all that much faster...) |
Additional dumb question; Do you know how I can supress warnings of "Filtered IamDataFrame is empty"? (To get the input, I filter for variables I need and check if the filter is empty to decide whether to take the data from the RCMIP ssp245 or from the given input. Then many of those filters will be empty, and I'd prefer not to get inundated with those warnings...) |
The warning comes from this line I think: https://github.com/IAMconsortium/pyam/blob/master/pyam/core.py#L1339 if len(idx) == 0:
logger.warning('Filtered IamDataFrame is empty!') Maybe something like import logging
logging.getLogger('pyam').setLevel(logging.DEBUG) can suppress these warnings. Possibly best to switch this back to |
Good suggestion! Only tweak, you'll want to set the logging level higher, not lower so it'll be import logging
logging.getLogger('pyam').setLevel(logging.ERROR) |
Whoopsie, thanks @znicholls! 😄 |
Thank you both, that worked! |
Is there a full list of possible output variables with expected units somewhere, or is it just the RCMIP ones? |
Names aren't perfect (if you can use RCMIP names that's probably better but we can also do internal mappings if needed) but this should list should hopefully be obvious enough? Units don't really matter (scmdata will convert without much trouble if needed) but if you follow RCMIP units you won't go wrong. If you can build it so adding more variables later (if needed) isn't a massive issue that would be ideal. Key variables
Extras if you have them
|
Ok, thanks that is helpful. And yes, the plan is to make it relatively (whatever that means) easy to include more variables later. |
Ok, finally made a pull request. I think that it in principle works (in terms of, getting inputs running and delivering outputs in the correct format, they should also be roughly calibrated as before, but I've not done much testing of the actual outputs). It's also not based environment variables, but rather on adding inputs as extra files. |
Turn on windows tests in CI
Hi,
Just to leave an issue that I will be attempting to make a Cicero-SCM-runner. I guess the appropriate thing to do is to make my own fork and the make a pull-request later. Sound ok?
best,
Marit
The text was updated successfully, but these errors were encountered: