Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added sonarcloud Github Action #1243

Closed
wants to merge 5 commits into from
Closed

feat: Added sonarcloud Github Action #1243

wants to merge 5 commits into from

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Apr 26, 2023 •
edited
Loading

feat: Added sonarcloud Github Action
fixes: #1242

@pascalwilbrink pascalwilbrink requested a review from juancho0202 May 3, 2023 09:18
@pascalwilbrink pascalwilbrink changed the title Create sonarcloud.yml feat: Added sonarcloud Github Action May 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juancho0202
Copy link
Contributor

@pascalwilbrink let's apply the same principle here of splitting the process into an unprivileged build workflow and a subsequent one triggered by workflow_run to have access to the Sonarcloud secret and analyze forked PRs

Stef3st
Stef3st suggested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before implementing we might want to check what rules/boundries we'd like to apply here

.github/workflows/sonarcloud.yml
pull_request:
branches:
- 'main'
- 'develop'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no develop branch on open-scd. This can be removed

.github/workflows/sonarcloud.yml
pull_request_target:
branches:
- 'main'
- 'develop'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no develop branch on open-scd. This can be removed

@trusz
Copy link
Member

trusz commented Aug 22, 2023

Is this PR still relevant?

@trusz
Copy link
Member

trusz commented Sep 6, 2023

It is weird that sonarcloud did not find anything. We have to check the configs.

@juancho0202
Copy link
Contributor

It is weird that sonarcloud did not find anything. We have to check the configs.

@trusz it is weird because if you navigate to their analysis of the main branch there are 45 bugs detailed in there: https://sonarcloud.io/project/issues?resolved=false&id=openscd_open-scd

@trusz
Copy link
Member

trusz commented Jul 18, 2024

The SonarCloud projects does not exist anymore. I will close this PR, but we can reopen it again if we want to proceed with SonarCloud

@trusz trusz closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st requested changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

Assignees
No one assigned
Labels
PR: Under Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpenSCD to SonarCloud
4 participants
@pascalwilbrink @juancho0202 @trusz @Stef3st