Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create virtual IED does not consider multiple instances of a LNType within a function #1567

Open
BurTah00 opened this issue Aug 9, 2024 · 5 comments
Assignees

Comments

@BurTah00
Copy link

BurTah00 commented Aug 9, 2024

Describe the bug
When the user assigns multiple instances of a same LNType (even though instance numbers/prefixes are different) to a Function element;
They are visualized just as normal with no problem like below;
image

Next, user creates a Virtual IED out of Functions which should turn out to LDs including those LNs within; (expected)
image

But at the end, it turns out to only last or first LN is included in the datamodel, and others are ignored.

Expected behavior
Expectation is all LNs are part of the datamodel of virtual IED, allocated under LD that is the name of Function element.

Sample SCL below:
DigSub 2 (5) (6).zip

@BurTah00 BurTah00 added the Kind: Bug Something isn't working label Aug 9, 2024
@Sander3003
Copy link
Member

Thanks for the report!

@Sander3003
Copy link
Member

@DavoodSooran can you take a look at it?

@JakobVogelsang
Copy link
Collaborator

I just tried it out myself and can confirm it is a bug!

@DavoodSooran
Copy link
Contributor

@Sander3003

As Burak explained, I also added some additional explanations to help developers resolve this issue. In the substation plug-in, when a user assigns multiple instances of the same LNType to a Function element, it should be visualized as shown below:

image

After that, when the user creates a Virtual IED from the Functions, the LDs should include all the defined LNs.

image

However, the current issue is that only the last LN is included in the data model, while the others are ignored.

image

Expected behavior
As Burak mentioned, the expected result is that all LNs should be included in the data model of the virtual IED, allocated under the LD that corresponds to the name of the Function element. Below is the expected outcome after creating the virtual IED:

image

@illia-solovei-s1
Copy link

Notes for takeover

Done

  • Added lnInst consideration on element string creation (see packages/openscd/src/foundation.ts)

Next steps

  • Take a closer look at the manually adjusted tests. Were they generated automatically using `web/test-runner'? Does it make sense to customize them manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review
Development

No branches or pull requests

6 participants