Skip to content

Z Meeting notes, 2022 05 02

Steven Haesendonckx edited this page May 2, 2022 · 2 revisions

Joana testing of cuminc

  • examples will remain in estimation function untill users complain

  • tidycmprsk has conf_level argument instead of conf.int and therefore we need to define the argument inside the function already instead of relying on the ellipsis. => action to update the testing for conf.int argument (Steven to do)

  • Joana will update testing for other cuminc dependent functions

Alexandra COX

  • issues with export functions. Daniel will offer help if Alexandra puts together a small example
    • devtools::document()
    • rebuild and install => issue solved during the meeting => action Alexandra to include testing of conf.int argument

Update Ardalan rowgutter between graph and risktable

  • PR has been updated. => Steven to review

  • Will adress #254

Milestone review

  • #299 Suggested packages are not checked on user end. Update version in description file + potentially add rlang::check installed package
  • #304 Steven and Daniel to look at. Post-Meeting Note SH 02MAY2022. Agreed to skip for next CRAN release.
  • #331 should be reviewed by Mark and James
  • #334 lets do this at the end of the sprint. => action everyone review link of maintainer of styler to see preferred option
  • #344 Ardalan will take this one from Charlotta
  • #350 Mark. See who can take over if Mark does not have time.

Misc

  • Daniel will add Rproj file as it is easier for him
  • Next meeting Next week Monday