Z Meeting notes, 2020 12 03

General agreements

1. Some parts of the code use tibbles, others data.frames. What should be agree on?
   • data.frames since we don't need the performance boost tibbles can give and it would add another dependence of tibble
2. function names are quite long?
   • shorten terms like "table" to "tbl"?
   • remove "vr_"? No to avoid namespace clashes
   • be less explicit in the names? Something to think about. It is a trace off between being lazy and being explicit. Best to fix early on
3. authoring notes on individual R files?
   • Include refactoring as authorship?
     • No, remove such metadata from files and track authorship in GitHub history

Function development

get_pval

Steven and Alexandra are working on adding test for trend. Output is a dataframe.

For tables: pval to compare strata is missing - implement a function for table_one objects?

• call add_pvalue on the table object and then render table?
• Inverse as implemented in plot

Testing

Steven and Alexandra will add testing for get_pval to serve as example

Steven will share his knowledge about testthat with Rebecca Marc will check in on people that might be able to give quality info on CI/CD

• Do it on the 16.12? Mark will send a mail

Timelines

Target date for CRAN release?

• We should go through the todos to decide what we need for the release and what are just nice-to-haves?
  • documentation documentation documentation
  • more extensive testing -> Alex and Steven will work on some examples?
• Charlotta and Rebecca will poach on N. :D