Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

476: be more robust against TMB version/order #478

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

danielinteractive
Copy link
Collaborator

closes #476

Copy link
Contributor

github-actions bot commented Oct 10, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  69       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       230       3  98.70%   420, 482, 512
R/interop-car.R               130       1  99.23%   9
R/interop-emmeans.R            51       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       0  100.00%
R/satterthwaite.R             116      12  89.66%   238-249
R/skipping.R                    8       0  100.00%
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               294       3  98.98%   162, 306-307
R/tmb.R                       304       1  99.67%   206
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     223      13  94.17%   283-293, 453, 482, 549
R/zzz.R                        77      31  59.74%   7-31, 64-69, 99, 127, 147
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    78       0  100.00%
TOTAL                        3401     105  96.91%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R        +3       0  +0.08%
R/zzz.R          +5      +5  -4.15%
TOTAL            +8      +5  -0.14%

Results for commit: e6194f3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
utils 👶 $+0.01$ h_tmb_version_sufficient_works_as_expected

Results for commit 9b1911e

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

Unit Tests Summary

    1 files     46 suites   27s ⏱️
  516 tests   476 ✅ 40 💤 0 ❌
1 976 runs  1 927 ✅ 49 💤 0 ❌

Results for commit e6194f3.

@danielinteractive danielinteractive merged commit 9de9a7e into main Oct 11, 2024
23 of 24 checks passed
@danielinteractive danielinteractive deleted the 476_check_tmb_fix branch October 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation order of TMB and mmrm is critical
2 participants