Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14: Add meta_analytic_samples wrapper #17

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

danielinteractive
Copy link
Collaborator

closes #14

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.34%. Comparing base (ceb3c13) to head (5182bb2).

Files Patch % Lines
src/meta_analysis.jl 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   94.80%   95.34%   +0.54%     
==========================================
  Files           4        4              
  Lines          77       86       +9     
==========================================
+ Hits           73       82       +9     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@brockk brockk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine. The renames are clearer than their legacy versions. The new tests are useful. No controversy here! Thanks

@brockk brockk merged commit fe52f13 into main Mar 1, 2024
4 checks passed
@brockk
Copy link
Collaborator

brockk commented Mar 1, 2024

I squashed and merged. If in general you prefer that responsibility to stay with PR creator, pls say!

@danielinteractive danielinteractive deleted the 14_meta_analytic_samples branch March 18, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add meta_analytic_samples wrapper
2 participants