Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch canary service selector from PodTemplateMetadata #243

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Patch canary service selector from PodTemplateMetadata #243

merged 4 commits into from
Dec 9, 2024

Conversation

lujiajing1126
Copy link
Contributor

@lujiajing1126 lujiajing1126 commented Nov 29, 2024 •
edited
Loading

Ⅰ. Describe what this PR does

  • Allow to overwrite existing service selector if PodTemplateMetadataPatch exists for Canary style
  • Add a feature gate to allow appending pod labels to the service selector even if the labels does not exist in the stable service

Ⅱ. Does this pull request fix one issue?

Fix #241

Ⅲ. Special notes for reviews

@lujiajing1126
patch canary service selector
5e0c576 
Signed-off-by: Megrez Lu <[email protected]>
@lujiajing1126
check null
cb609fa 
Signed-off-by: Megrez Lu <[email protected]>
@lujiajing1126
fix nil check
8880544 
Signed-off-by: Megrez Lu <[email protected]>
@lujiajing1126 lujiajing1126 changed the title patch canary service selector Patch canary service selector from PodTemplateMetadata Nov 29, 2024
@lujiajing1126 lujiajing1126 marked this pull request as ready for review November 29, 2024 06:32
@lujiajing1126
remove len check
dc83e23 
Signed-off-by: Megrez Lu <[email protected]>
furykerry
furykerry reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@zmberg PTAL

@zmberg zmberg merged commit 056c77d into openkruise:master Dec 9, 2024
21 of 22 checks passed
@lujiajing1126 lujiajing1126 deleted the overwrite-service-selector branch December 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: support fine-grained Canary Service manipulation
3 participants
@lujiajing1126 @furykerry @zmberg