Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity illustration display #54

Open
jbelien opened this issue Dec 14, 2020 · 4 comments
Open

Activity illustration display #54

jbelien opened this issue Dec 14, 2020 · 4 comments
Assignees
Labels

Comments

@jbelien
Copy link
Member

jbelien commented Dec 14, 2020

There is some issue with the activity illustration (see https://okbe-website.netlify.app/activities/bike-data-project):
image

@jbelien jbelien added bug Something isn't working design labels Dec 14, 2020
@auloin
Copy link
Contributor

auloin commented Dec 15, 2020

Is the issue about the picture not fully visible? I'm making sure the image takes the height of the container and using object-fit: cover which hides some part of the image in the process.

@jbelien
Copy link
Member Author

jbelien commented Dec 15, 2020

Is the issue about the picture not fully visible?

Yes :)

@auloin auloin removed the bug Something isn't working label Dec 15, 2020
@auloin
Copy link
Contributor

auloin commented Dec 15, 2020

Any suggestion on how to make this better?

@jbelien
Copy link
Member Author

jbelien commented Dec 15, 2020

I wouldn't use object-fit: cover.

I would try object-fit: contain; and making sure the image is centered vertically (or keeping it at the top, I don't know what would look best) ?

@mariedevos Any idea ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants