-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: cd2es: Converting climate data to energy system input data #7216
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 Failed to discover a valid open source license |
Five most similar historical JOSS papers: TopoPyScale: A Python Package for Hillslope Climate Downscaling MetSim: A Python package for estimation and disaggregation of meteorological data CLOVER: A modelling framework for sustainable community-scale energy systems autumn: A Python library for dynamic modelling of captured CO_2 cost potential curves helios: An R package to process heating and cooling degrees for GCAM |
Hi @Schneewittchen7001 and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:
In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. |
Hello, thanks for all the information. I would suggest the following reviewers: |
Hello @Schneewittchen7001, here are the things you can ask me to do:
|
I licensed my work with the gnu general public license, version 3. I am not sure why it is not recognized, if it something I did wrong, I would be happy to fix it. |
@Schneewittchen7001 Sorry for my delay. I think the license can’t be automatically detected because it isn’t called LICENSE. The name LICENSE is preferable because it conventionally applies to the whole project unless specified otherwise, versus a license file in the repo (which could be one of several and might apply to only one file or to many). This project appears to use a copyright notice in every source file so it's not ambiguous, though it is an extra step. Note that dual-licensed projects will often have multiple files, e.g., LICENSE-MIT and LICENSE-Apache , so even by best practices, there may not be a file named LICENSE. So, it could be simpler to go with a single LICENSE file to apply to the whole project, unless that isn't your intention. |
paper:
|
@editorialbot generate pdf |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Five most similar historical JOSS papers: helios: An R package to process heating and cooling degrees for GCAM osiris: An R package to process climate impacts on agricultural yields for the Global Change Analysis Model OpenSCM Two Layer Model: A Python implementation of the two-layer climate model diyepw: A Python package for Do-It-Yourself EnergyPlus weather file generation autumn: A Python library for dynamic modelling of captured CO_2 cost potential curves |
@editorialbot check repository |
@editorialbot generate pdf |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
@editorialbot invite @AdamRJensen as editor |
Invitation to edit this submission sent! |
@AdamRJensen can you edit this submission? |
@editorialbot assign @AdamRJensen as editor |
Assigned! @AdamRJensen is now the editor |
👋 @phil-sandwell & @arbennett, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html |
@kthyng can you remove the waitlist tag on this submission? Thanks 🙏 |
Got it! You should have permission to do so, for future reference. If you can't, check in on the dev channel. |
👋 @koldunovn & @ciara-donegan, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html |
Hi @AdamRJensen, I would be happy to review! |
Sorry, as @kthyng already knows, I tend to be |
@editorialbot add @ciara-donegan as reviewer Wonderful 🥳 |
@ciara-donegan added to the reviewers list! |
👋 @hcbloomfield19 any interest in reviewing this JOSS submission? |
@Schneewittchen7001 could you suggest some additional reviewers (please list their GH usernames but without the @ symbol). @hcbloomfield19 we'd still very much appreciate it if you have time to review this JOSS submission? 😄 |
@Schneewittchen7001 could you please suggest some additional reviewers (preferably but commenting with their GH user names in this thread, but without the @ symbol to avoid tagging them just yet). |
@AdamRJensen Sorry for my late reply. I would suggest the following reviewers: |
👋 @Zeitsperre & @nmstreethran, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html |
@AdamRJensen Thanks for thinking of me, but I'm a bit over capacity at the moment. Next time! |
@AdamRJensen yes, I'm happy to review |
@editorialbot add @nmstreethran as reviewer |
@nmstreethran added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #7541. |
Submitting author: @Schneewittchen7001 (Leonie Plaga)
Repository: https://gitlab.ruhr-uni-bochum.de/ee/cd2es
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @AdamRJensen
Reviewers: @ciara-donegan, @nmstreethran
Managing EiC: Kristen Thyng
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @Schneewittchen7001. Currently, there isn't a JOSS editor assigned to your paper.
@Schneewittchen7001 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: