Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: COBRAPRO: A MATLAB toolbox for Physics-based Battery Modeling and Co-simulation Parameter Optimization #6540

Closed
editorialbot opened this issue Mar 26, 2024 · 56 comments
Closed

[PRE REVIEW]: COBRAPRO: A MATLAB toolbox for Physics-based Battery Modeling and Co-simulation Parameter Optimization #6540

editorialbot opened this issue Mar 26, 2024 · 56 comments
Assignees
@brosaplanella @mbarzegary @BradyPlanden @yuefan98
Labels
Matlab pre-review TeX Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 26, 2024 •
edited
Loading

Submitting author: @COBRAPROsimulator (Sara Ha)
Repository: https://github.com/COBRAPROsimulator/COBRAPRO
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @mbarzegary
Reviewers: @yuefan98, @BradyPlanden, @brosaplanella
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891"><img src="https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891/status.svg)](https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891)

Author instructions

Thanks for submitting your paper to JOSS @COBRAPROsimulator. Currently, there isn't a JOSS editor assigned to your paper.

@COBRAPROsimulator if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Mar 26, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1136.1 files/s, 139515.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          52            771           2787           2832
TeX                              1             20              0            217
Markdown                         2             36              0            191
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            56            828           2791           3258
-------------------------------------------------------------------------------

Commit count by author:

    83	COBRAPROsimulator
     1	CO-simulation BatteRy modeling for Accelerated PaRameter Optimization (COBRAPRO)

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1097

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1149/1.2221597 is OK
- 10.1149/2.0301603jes is OK
- 10.1016/j.energy.2022.125966 is OK
- 10.1149/1945-7111/ab7bd7 is OK
- 10.1149/2.0551509jes is OK
- 10.1149/2.0321816jes is OK
- 10.1149/1945-7111/ab9050 is OK
- 10.5334/jors.309 is OK
- 10.1149/2.0291607jes is OK
- 10.1149/2.0171711jes is OK
- 10.1016/j.jpowsour.2016.12.083 is OK
- 10.4271/2023-01-5047 is OK
- 10.1149/1945-7111/ac201c is OK
- 10.1149/1945-7111/ac22c8 is OK
- 10.1016/j.compchemeng.2011.01.003 is OK
- 10.1016/j.compchemeng.2015.07.002 is OK
- 10.1149/1945-7111/ad1293 is OK

MISSING DOIs

- No DOI given, and none found for title: COMSOL Multiphysics&copy; v. 6.2
- No DOI given, and none found for title: Battery Design Module User’s Guide, COMSOL Multiph...
- No DOI given, and none found for title: fastDFN

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hello @COBRAPROsimulator, thanks for your interest in JOSS. Unfortunately, we do not have an editor in this area available to edit this submission at the moment, so I have to place this on our waitlist until someone frees up.

In the meantime, any reviewer suggestions would be welcome.

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Mar 26, 2024
@COBRAPROsimulator
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @COBRAPROsimulator, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@COBRAPROsimulator
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@COBRAPROsimulator
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@COBRAPROsimulator
Copy link

Thank you @kyleniemeyer! Here is a list of potential reviewers who already agreed to review for JOSS:

  • leeberty84
  • yuefan98
  • BradyPlanden
  • DEARLIBS
  • medullar
  • yaomz16
  • tomtranter
  • EricaEgg

Here is a list of potential reviewers who are not on the JOSS reviewer list:

  • petermattia
  • martinjrobins
  • robertwtimms

@COBRAPROsimulator
Copy link

@kyleniemeyer, could you clarify if you mean that there is no JOSS editor suitable for COBRAPRO? Or do you mean that there is an appropriate JOSS editor for our code, but that they are not available at this moment (we noticed Rachel Kurchin could be a good match for our paper)?

If the latter, would you be able to give us an estimated time of when our paper would be assigned an editor?

Thank you,
Sara

@COBRAPROsimulator
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@COBRAPROsimulator
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@COBRAPROsimulator
Copy link

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@kyleniemeyer
Copy link

@COBRAPROsimulator I mean that we do not currently have one available - we limit the workload of our editors and how many simultaneous submissions they are handling. I can't quite predict how long it will take, because we have a queue of submissions.

@kyleniemeyer
Copy link

@editorialbot invite @mbarzegary as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@mbarzegary
Copy link

@editorialbot assign me as editor

@yaomz16
Copy link

yaomz16 commented Apr 26, 2024 via email

@mbarzegary
Copy link

@yuefan98 we aim for reviews to be completed within about 2-4 weeks after the start of the revision process.

@mbarzegary
Copy link

Hi @TomTranter 👋
Do you have time for reviewing another battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf
Software: https://github.com/COBRAPROsimulator/COBRAPRO

@TomTranter
Copy link

Hi @mbarzegary unfortunately not

@BradyPlanden
Copy link

@mbarzegary Happy to review this.

@mbarzegary
Copy link

@editorialbot add @yuefan98 as reviewer

@editorialbot
Copy link
Collaborator Author

@yuefan98 added to the reviewers list!

@mbarzegary
Copy link

@editorialbot add @BradyPlanden as reviewer

@editorialbot
Copy link
Collaborator Author

@BradyPlanden added to the reviewers list!

@mbarzegary
Copy link

Hi @ma-sadeghi 👋
Do you have time for reviewing another battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf
Software: https://github.com/COBRAPROsimulator/COBRAPRO

@mbarzegary
Copy link

Hi @jepegit 👋
Since you have recently published your software, would you be willing to review a battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf
Software: https://github.com/COBRAPROsimulator/COBRAPRO

@mbarzegary
Copy link

Hi @jtock, @joshuaeh, @mdmurbach, @olejandro, @mfleschutz 👋
Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf
Software: https://github.com/COBRAPROsimulator/COBRAPRO

@mfleschutz
Copy link

Hi @mbarzegary,

Thank you for considering me for this review. Unfortunately, I am unable to commit to reviewing this submission for JOSS at this time.

Best regards

@joshuaeh
Copy link

Hi @mbarzegary,

I appreciate the vote of confidence, I wouldn't be able to give meaningful insights in the area unfortunately.

JH

@TomTranter
Copy link

I suggest @brosaplanella

@TomTranter
Copy link

Also @DrSOKane

@mbarzegary
Copy link

Thanks @TomTranter

@mbarzegary
Copy link

Hi @brosaplanella and @DrSOKane 👋
Considering your expertise, would any of you be willing to review this battery modeling work for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf
Software: https://github.com/COBRAPROsimulator/COBRAPRO

@brosaplanella
Copy link

Hi! I am at full capacity ATM. The earliest I can guarantee a review is the 5th of July. If that works, please assign me to it.

@mbarzegary
Copy link

@brosaplanella thanks. As you know, we usually aim to finish the first review round in 4 weeks, but I think it's worth to prolong it a bit to have your review as well. I assign you as the reviewer and you can do it early July.

@mbarzegary
Copy link

@editorialbot add @brosaplanella as reviewer

@editorialbot
Copy link
Collaborator Author

@brosaplanella added to the reviewers list!

@mbarzegary
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6803.

@ma-sadeghi
Copy link

@mbarzegary Sorry I couldn't get back to you earlier. Unfortunately, I can't atm, but looks like you've already found reviewers, so all good.

@jtock
Copy link

jtock commented Jun 4, 2024

@mbarzegary Sorry for my late response and thank you for considering me as an author! I could also not join this review, but it works already. Best wishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

@mbarzegary mbarzegary

@BradyPlanden BradyPlanden

@yuefan98 yuefan98

Labels
Matlab pre-review TeX Track: 3 (PE) Physics and Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests