-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ATHENA: A Fortran package for neural networks #6492
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Review checklist for @awvwgkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @HaoZeke, a few questions. Firstly, the paper version is now 1.3.0 (updated around 2-3 days ago, so before the paper went into review). Can this be updated here? Second, I notice that there are still some issues with DOIs for references. I assume I should fix them: Should I add them to the paper.bib as urls (it appears they don’t work exactly as DOIs from the journal)? Or should I wait for review to be over now? |
Hi @nedtaylor, great questions. I wouldn't worry about the version for now, at the end of the review we'll set the version to the latest (which should also include changes in response to the reviewers, if any). Modifying the paper.bib should be alright, but can also wait until the first round of reviews are in (you can mention it in the response / changes made, if any). |
Review checklist for @jrybarczykConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @milancurcic, @awvwgk, @jrybarczyk, just wanted to check in / provide a reminder regarding the reviews. |
Thanks @HaoZeke. I don't see my checklist in this thread, can you take a look? |
Ah, sorry, if you comment |
Review checklist for @milancurcicConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @HaoZeke - this one has been still for a while, could you check in to see how things are going? Thanks! |
@nedtaylor could you take a look at the issues raised by the reviewers and provide an ETA? |
I finished my review, the paper and the repo look all good for JOSS. |
Hi @HaoZeke. From what I can see, the three issues opened are:
From what I can see, these have been resolved. All issues have been kept open as requested for the review process until approved for the new paper branch version.
If I haven't addressed these issues properly and there is more to do on my end, then please let me know. I'm eager to do whatever I can to continue the process. If there are other issues I have missed, please point me to them. |
@nedtaylor can you merge the updates into |
|
@nedtaylor it seems like all the NeurIPS ones are to be coded as Also the Missing ones are a suggestion, so I can also just let is slide as is. |
Maybe this information will help for clarity and in determining how to handle these. I've set both DropBlock and Batchnorm papers as |
@nedtaylor and @HaoZeke - it is fine to have a justification here for the missing DOI. If there is none available for the record, regardless of the specification, then we will be OK with publishing it as such. The more critical notices are those that get labeled as invalid, which it looks like you don't have any of those in your listing. Thanks! |
@editorialbot recommend-accept Thanks for the additional context and quick turnaround @nedtaylor and @crvernon!! |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5573, then you can now move forward with accepting the submission by compiling again with the command |
🔍 checking out the following:
|
@editorialbot generate pdf |
I've had a quick look through the final proof and am happy with it. Thanks very much, @HaoZeke and @crvernon for the fantastic editorial work! 😄 And thanks to the reviewers, (@awvwgk, @jrybarczyk, and @milancurcic ) for the massive amount of work and dedication put towards reviewing this paper and the code! I greatly appreciate it! 😄 |
👋 @nedtaylor - You are almost there before we are ready to accept this submission for publication. Please correct the following (no need to make a new release for these): In the paper:
Let me know when these have been addressed. Thanks! |
Thanks @crvernon, I'll get on with that right away. :) |
@crvernon Also, just to confirm, I think the second to last issue is line 64, not 54. Am I correct? I cannot tick off the list, so I’ll make my own comment with them.
|
@crvernon I have addressed the errors in the paper and the corrections can be found in the |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @nedtaylor! Many thanks to @HaoZeke for editing and @milancurcic, @awvwgk, and @jrybarczyk for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @nedtaylor (Ned Thaddeus Taylor)
Repository: https://github.com/nedtaylor/athena
Branch with paper.md (empty if default branch): paper
Version: 1.3.3
Editor: @HaoZeke
Reviewers: @milancurcic, @awvwgk, @jrybarczyk
Archive: 10.6084/m9.figshare.26158630
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@milancurcic & @awvwgk & @jrybarczyk, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @HaoZeke know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @awvwgk
📝 Checklist for @jrybarczyk
📝 Checklist for @milancurcic
The text was updated successfully, but these errors were encountered: