Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: MetSim: A Python package for estimation anddisaggregation of meteorological data #2025

Closed
whedon opened this issue Jan 17, 2020 · 16 comments

Comments

@whedon
Copy link

whedon commented Jan 17, 2020

Submitting author: @arbennett (Andrew Bennett)
Repository: https://github.com/UW-Hydro/MetSim
Version: v2.2.0
Editor: @sjpfenninger
Reviewers: @Chilipp, @dsryberg

Author instructions

Thanks for submitting your paper to JOSS @arbennett. Currently, there isn't an JOSS editor assigned to your paper.

@arbennett if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 17, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 17, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.16 s (212.4 files/s, 42820.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            812           1906           2600
reStructuredText                 7            181            124            495
Markdown                         3             52              0            196
TeX                              1             11              0            136
YAML                             5              4              2             83
JSON                             1              0              0             32
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            33           1064           2038           3552
-------------------------------------------------------------------------------


Statistical information for the repository '2025' was gathered on 2020/01/17.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Andrew Bennett                  31           738            661            7.22
Bart Nijssen                    10            75             25            0.52
Elizabeth Clark                  2             9              6            0.08
Joe Hamman                      32          1000            512            7.80
Joseph Hamman                   25          3095            614           19.14
Kostas Andreadis                 1             3              0            0.02
Manabendra Saharia               1             3              3            0.03
arbennett                      198          6950           4871           61.00
kwhitney727                     11           486            290            4.00
ted                              1            27             12            0.20

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Andrew Bennett             2045          277.1         25.8               18.73
Bart Nijssen                 29           38.7          2.4               13.79
Elizabeth Clark               6           66.7         18.6               33.33
Joe Hamman                  379           37.9         31.0               24.01
Joseph Hamman              2688           86.8         17.3               14.29
kwhitney727                 153           31.5         24.8               16.34
ted                          18           66.7          9.8                0.00

@kyleniemeyer
Copy link

Hi @sjpfenninger, welcome to the team! Could you edit this submission for us?

@whedon
Copy link
Author

whedon commented Jan 17, 2020

Reference check summary:

OK DOIs

- 10.1145/2833157.2833162 is OK
- 10.5334/jors.148 is OK
- 10.1016/0266-9838(86)90020-1 is OK
- 10.1016/S0168-1923(98)00126-9 is OK
- 10.1016/j.agrformet.2013.03.003 is OK
- 10.1175/JHM-D-18-0203.1 is OK
- 10.1029/94JD00483 is OK

MISSING DOIs

- https://doi.org/10.25080/majora-7b98e3ed-013 may be missing for title:  Dask: Parallel Computation with Blocked algorithms and Task Scheduling 

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jan 17, 2020

@sjpfenninger
Copy link

@kyleniemeyer Yes I am happy to edit this.

@kyleniemeyer
Copy link

@whedon assign @sjpfenninger as editor

@whedon
Copy link
Author

whedon commented Jan 21, 2020

OK, the editor is @sjpfenninger

@sjpfenninger
Copy link

I have contacted potential reviewers by email. @arbennett let me know if you have suggestions for reviewers.

@sjpfenninger
Copy link

@whedon assign @Chilipp as reviewer

@whedon whedon assigned Chilipp and sjpfenninger and unassigned sjpfenninger Jan 23, 2020
@whedon
Copy link
Author

whedon commented Jan 23, 2020

OK, @Chilipp is now a reviewer

@sjpfenninger
Copy link

@whedon add @dsryberg as reviewer

@whedon
Copy link
Author

whedon commented Jan 27, 2020

OK, @dsryberg is now a reviewer

@sjpfenninger
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Jan 27, 2020

OK, I've started the review over in #2042.

@whedon whedon closed this as completed Jan 27, 2020
@sjpfenninger
Copy link

@Chilipp and @dsryberg, thanks for agreeing to review! Head over to the review issue #2042 for the review process. Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants