Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR #16124

Closed
wants to merge 5 commits into from
Closed

8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR #16124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1138dc3
8317763:Restrict AVX512 intrinsics for Arrays.sort() methods to Intel…
vamsi-parasa Oct 10, 2023
386bdd8
pragma workround for GCC12 bug
vamsi-parasa Oct 10, 2023
a565f1d
fix whitespace in build script
vamsi-parasa Oct 10, 2023
1de07fb
Add @ForceInline annotation to insertion and mixedInsertion sort
vamsi-parasa Oct 11, 2023
9bce680
Revert @ForceInline annotations for small array sort methods
vamsi-parasa Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/stubGenerator_x86_64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4173,7 +4173,7 @@ void StubGenerator::generate_compiler_stubs() {
}

// Load x86_64_sort library on supported hardware to enable avx512 sort and partition intrinsics
if (UseAVX > 2 && VM_Version::supports_avx512dq()) {
if (VM_Version::is_intel() && UseAVX > 2 && VM_Version::supports_avx512dq()) {
vamsi-parasa marked this conversation as resolved.
Show resolved Hide resolved
void *libsimdsort = nullptr;
char ebuf_[1024];
char dll_name_simd_sort[JVM_MAXPATHLEN];
Expand Down
14 changes: 7 additions & 7 deletions src/java.base/share/classes/java/util/DualPivotQuicksort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ interface PartitionOperation<A> {
/**
* Partitions the specified range of the array using the given pivots.
*
* @param a the array to be sorted
* @param low the index of the first element, inclusive, to be sorted
* @param high the index of the last element, exclusive, to be sorted
* @param a the array to be partitioned
* @param low the index of the first element, inclusive, to be partitioned
* @param high the index of the last element, exclusive, to be partitioned
* @param pivotIndex1 the index of pivot1, the first pivot
* @param pivotIndex2 the index of pivot2, the second pivot
*/
Expand All @@ -178,13 +178,13 @@ interface PartitionOperation<A> {
/**
* Partitions the specified range of the array using the two pivots provided.
*
* @param elemType the class of the array to be sorted
* @param array the array to be sorted
* @param elemType the class of the array to be partitioned
* @param array the array to be partitioned
* @param offset the relative offset, in bytes, from the base address of
* the array to partition, otherwise if the array is {@code null},an absolute
* address pointing to the first element to partition from.
* @param low the index of the first element, inclusive, to be sorted
* @param high the index of the last element, exclusive, to be sorted
* @param low the index of the first element, inclusive, to be partitioned
* @param high the index of the last element, exclusive, to be partitioned
* @param pivotIndex1 the index of pivot1, the first pivot
* @param pivotIndex2 the index of pivot2, the second pivot
* @param po the method reference for the fallback implementation
Expand Down