Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support arbitrary table fields in postgres destination sync #92

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

openint-bot
Copy link
Collaborator

@openint-bot openint-bot commented Nov 23, 2024

TODO

  • Respect existing do not migrate flag
  • Rename custom links to _custom prefix
  • Migrate existing links in DB to new prefix
  • Deploy new version ensure app loads for existing custom links users
  • hide custom prefixes from UI

Important

Support for arbitrary table fields in PostgreSQL destination sync with custom schema handling and enhanced utilities.

  • Behavior:
    • Support for arbitrary table fields in PostgreSQL destination sync added.
    • Custom schemas are handled in server.ts and server.spec.ts.
    • New agLink function in agLink.ts for custom link handling.
  • Testing:
    • Added tests for agLink in agLink.spec.ts.
    • Added tests for database operations in index.spec.ts and upsert.spec.ts.
  • Utilities:
    • New utility functions in utils.ts for schema inference and migration.
    • Updated dbUpsert function in upsert.ts for enhanced upsert operations.
  • Misc:
    • Updated dependencies in package.json files across multiple packages.
    • Removed deprecated ag_column_rename link in sync-service.ts.

This description was created by Ellipsis for 4bfbbde. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:49am

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4bfbbde in 1 minute and 40 seconds

More details
  • Looked at 2559 lines of code in 34 files
  • Skipped 3 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. packages/custom-links/agLink.ts:42
  • Draft comment:
    Remove or replace console.log with a proper logging mechanism.
// console.log('raw data for agLink', op.data.entityName)
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code in agLink.ts has a console.log statement that seems to be used for debugging purposes. This should be removed or replaced with a proper logging mechanism before merging into production.
2. packages/custom-links/agLink.ts:25
  • Draft comment:
    Address or remove the TODO comment regarding renaming the function.

  • Reason this comment was not posted:
    Confidence changes required: 50%
    The agLink.ts file has a TODO comment suggesting a rename of the function. This should be addressed or removed if no longer relevant.

3. packages/custom-links/agLink.ts:57
  • Draft comment:
    Address or remove the TODO comment regarding making the profile configurable.

  • Reason this comment was not posted:
    Confidence changes required: 50%
    The agLink.ts file has a TODO comment suggesting making the profile configurable. This should be addressed or removed if no longer relevant.

4. packages/custom-links/agLink.ts:45
  • Draft comment:
    Address or remove the TODO comment regarding sending the connection only once per agLink instantiation.

  • Reason this comment was not posted:
    Confidence changes required: 50%
    The agLink.ts file has a TODO comment suggesting sending the connection only once per instantiation. This should be addressed or removed if no longer relevant.

5. connectors/connector-postgres/def.ts:32
  • Draft comment:
    Address or remove the TODO comment regarding fixing support for Postgres.

  • Reason this comment was not posted:
    Confidence changes required: 50%
    The def.ts file has a TODO comment suggesting fixing support for Postgres. This should be addressed or removed if no longer relevant.

Workflow ID: wflow_Eq2WmL9lO3lOQSi5


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -90,7 +90,7 @@ jobs:
NODE_OPTIONS: --max-old-space-size=4096

- name: Run tests
run: pnpm run test::ci
run: POSTGRES_URL=postgres://postgres:test@localhost:5432/test pnpm run test::ci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid hardcoding database URLs in the workflow. Consider using environment variables or secrets for sensitive information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants