Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fli cannot create raw hazards #323

Closed
HamzaYusufJamal opened this issue Nov 20, 2024 · 2 comments
Closed

fli cannot create raw hazards #323

HamzaYusufJamal opened this issue Nov 20, 2024 · 2 comments

Comments

@HamzaYusufJamal
Copy link
Contributor

PR #322 implements hazard testing for all float instructions, but some instructions like fli cannot trigger certain types of hazards, leading to a false sub-100% coverage report. This issue serves to keep track of the required change for a fix.

@davidharrishmc
Copy link
Collaborator

It's ok that fli can't create raw hazards. Can you modify the coverpoint used for fli so you don't try to hit them?

@HamzaYusufJamal
Copy link
Contributor Author

This issue extends beyond fli, so we will need a lot of reviews of the testplans to make sure we check for the right hazard types. We are also not testing gpr hazards for any of the float instructions, which we should be doing. All of these are creating many false 100% reports. @coreyqh and I will work together on the review, and then I will need to make additional changes to testgen to account for the new coverpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants