Allow hard-wiring of PMP regions #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-platzer
requested review from
JeanRochCoulon and
zarubaf
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
❌ failed run, report available here. |
|
lgtm, I think we miss the configuration in some testbench :-) Maybe @cathales can help? 🥹 |
michael-platzer
force-pushed
the
michael-platzer/feature/constant-pmps
branch
from
3b15abe to
1ae5ec5
Compare
|
❌ failed run, report available here. |
michael-platzer
force-pushed
the
michael-platzer/feature/constant-pmps
branch
2 times, most recently
from
e397f5e to
3cc446a
Compare
|
❌ failed run, report available here. |
1 similar comment
|
❌ failed run, report available here. |
michael-platzer
force-pushed
the
michael-platzer/feature/constant-pmps
branch
from
3cc446a to
7a97ba5
Compare
|
❌ failed run, report available here. |
|
I tried a few things as far as I could parse the error messages from the logs but now it appears that the CI issues are unrelated to my changes. Does anyone have some feedback/suggestions as to how I could resolve these issues? |
|
Hi! We encountered similar issues while reviewing #1760.
|
This commit adds three new fields to the cva6_cfg_t configuration struct, which allow to specify reset values for the PMP configuration and address CSRs as well as optionally making invidiual PMP entries read-only. The purpose is to allow hard-wiring of certain regions' privileges, which is explicitely allowed by the RISC-V Privileged Architecture specification Machine-Level ISA, v1.12 (see Sect. 3.7).
michael-platzer
force-pushed
the
michael-platzer/feature/constant-pmps
branch
from
7a97ba5 to
84be727
Compare
|
Thanks @cathales for the suggestions! Added the missing modifications, so let's see whether it works now 🙂 |
|
✔️ successful run, report available here. |
rohan-10xe
pushed a commit
to 10x-Engineers/cva6
that referenced
this pull request
Jan 23, 2024
…up#1769) This commit adds three new fields to the `cva6_cfg_t` configuration struct, which allows to specify reset values for the PMP configuration and address CSRs as well as optionally making individual PMP entries read-only. The purpose is to allow hard-wiring of certain regions' privileges, which is explicitly allowed by the RISC-V Privileged Architecture specification Machine-Level ISA, v1.12 (see Sect. 3.7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new fields to the
cva6_cfg_tconfiguration struct, which allow to specify reset values for the PMP configuration and address CSRs as well as optionally making individual PMP entries read-only. The purpose is to allow hard-wiring of certain regions' privileges, which is explicitly allowed by the RISC-V Privileged Architecture specification Machine-Level ISA, v1.12 (see Sect. 3.7).Hard-wiring of PMP regions is useful whenever a SoC has memory regions with fixed properties and protection rules. Instead of relying on SW to setup the PMP regions correctly on every boot, with this PR regions may be initialized using the new parameters and optionally made read-only.