Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ld/st priv mode, sum & PMP iface signals to acc_dispatcher #1767

Conversation

michael-platzer
Copy link
Contributor

Hi, this PR adds 4 additional ports for the current load/store privilege mode, the current content of the sum field of the mstatus CSR, and the contents of the PMP configuration and address CSRs to the acc_dispatcher.

These signals are necessary to perform memory protection checks on memory requests originating from an accelerator in a custom implementation of the acc_dispatcher module. Those signals allow to determine the privilege mode of loads and stores performed by an accelerator and, for example, to add an instance of the pmp module to enforce the current physical memory protection rules on those requests.

This PR simply adds the necessary ports and connects the corresponding signals to the acc_dispatcher module. The protection checks that they enable need to be added to a custom implementation of the acc_dispatcher which interfaces with the respective accelerator.

CC @domenicw @zarubaf

Copy link
Contributor

✔️ successful run, report available here.

Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not touching anything inside CVA6 so merging.

@JeanRochCoulon JeanRochCoulon merged commit 37427a7 into openhwgroup:master Jan 16, 2024
19 checks passed
@michael-platzer michael-platzer deleted the michael-platzer/feature/accel-mem-protect branch January 18, 2024 08:59
rohan-10xe pushed a commit to 10x-Engineers/cva6 that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants