Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] CVA6 RTL Lint warnings for CV32A60X #1377

Closed
fatimasaleem opened this issue Sep 9, 2023 · 6 comments
Closed

[TASK] CVA6 RTL Lint warnings for CV32A60X #1377

fatimasaleem opened this issue Sep 9, 2023 · 6 comments
Assignees
@fatimasaleem
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Status:In Progress Work on this issue has started, but is not complete. Type:Lint Lint error or compile warning Type:Task Project related task

Comments

@fatimasaleem
Copy link
Contributor

fatimasaleem commented Sep 9, 2023 •
edited
Loading

Description

RTL Linting is used to verify adherence to specified design coding rules that prevent synthesis issues, functional bugs and enforce coding styles for readability & re-use. For that purpose, we have to enable lint warnings and remove/waive them where necessary.

Changes

Track and resolve the lint warnings in core/ directory

Current Status

This table specifies all the warnings related to lint in CVA6 RTL and classifies those into specific categories. The progress of all the Lint Issues will be maintained here.

Type of Lint Warning No. of Warnings Status PR
MODDUP 1 ToDo None
SELRANGE 28 ToDo None
WIDTHEXPAND ~90 In Progress None
WIDTHCONCAT 5 In Progress None
WIDTHTRUNC 22 In Progress None
UNOPTFLAT 19 ToDo None

Description of Done

Resolution of cva6/core/ directory lint problems
All the related lint waivers are in place
@fatimasaleem fatimasaleem converted this from a draft issue Sep 9, 2023
@fatimasaleem fatimasaleem added the Component:RTL For issues in the RTL (e.g. for files in the rtl directory) label Sep 9, 2023
@fatimasaleem fatimasaleem moved this to In Progress in CVA6 Project Task Board Sep 9, 2023
@fatimasaleem fatimasaleem self-assigned this Sep 9, 2023
@fatimasaleem fatimasaleem added the Status:In Progress Work on this issue has started, but is not complete. label Sep 9, 2023
@JeanRochCoulon JeanRochCoulon added CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration labels Sep 12, 2023
@fatimasaleem fatimasaleem added the Type:Lint Lint error or compile warning label Sep 13, 2023
@umerimran-10xe umerimran-10xe mentioned this issue Sep 15, 2023
Closed
3 tasks
@JeanRochCoulon JeanRochCoulon added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Oct 9, 2023
This was referenced Oct 10, 2023
Merged
Merged
@JeanRochCoulon
Copy link
Contributor

#1510 and #1520 have reduced the number of warnings. Do you have an udpdate of the above table to present this afternoon (West Shifted Meeting)?

@fatimasaleem
Copy link
Contributor Author

Type of Lint Warning No. of Warnings Status PR
MODDUP 0 Done None
SELRANGE 26 In Progress None
WIDTHEXPAND 60 In Progress None
WIDTHCONCAT 1 In Progress None
WIDTHTRUNC 18 In Progress None
UNOPTFLAT 12 In Progress None

@JeanRochCoulon JeanRochCoulon added the Type:Task Project related task label Oct 19, 2023
@JeanRochCoulon JeanRochCoulon changed the title CVA6 RTL Lint warnings for CV32A60X [TASK] CVA6 RTL Lint warnings for CV32A60X Oct 19, 2023
@fatimasaleem
Copy link
Contributor Author

Working PR #1529

@fatimasaleem
Copy link
Contributor Author

After the merge of the current PR, the status will be as follows

Type of Lint Warning No. of Warnings Status PR
MODDUP 0 Done None
SELRANGE 13 In Progress None
WIDTHEXPAND 34 In Progress None
WIDTHCONCAT 1 In Progress None
WIDTHTRUNC 7 In Progress None
UNOPTFLAT 12 In Progress None

This was referenced Oct 20, 2023
Merged
Merged
@fatimasaleem
Copy link
Contributor Author

Type of Lint Warning No. of Warnings Status
MODDUP 0 Done
SELRANGE 11 P2
WIDTHEXPAND 2 P2
WIDTHCONCAT 0 Done
WIDTHTRUNC 0 Done

@ASintzoff ASintzoff mentioned this issue Dec 5, 2023
Open
1 task
@JeanRochCoulon
Copy link
Contributor

@fatimasaleem Can you consider this task over ? The current Spyglass task will help to fix LINT errors.

@github-project-automation github-project-automation bot moved this from In Progress to Done - Ready for Review in CVA6 Project Task Board May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatimasaleem fatimasaleem

Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A60AX Part: Application configuration (former "step1") CV32A65X Part: Embedded configuration Status:In Progress Work on this issue has started, but is not complete. Type:Lint Lint error or compile warning Type:Task Project related task
Projects
CVA6 Project Task Board
Status: Done - Ready for Review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeanRochCoulon @fatimasaleem