Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of which bundles are installable add-ons #159

Open
ghys opened this issue Mar 2, 2019 · 1 comment
Open

Better detection of which bundles are installable add-ons #159

ghys opened this issue Mar 2, 2019 · 1 comment

Comments

@ghys
Copy link
Member

ghys commented Mar 2, 2019

The current assumption is that every subdirectory in the _addons_* directories of the docs' final branch are actual add-ons.
READMEs were recently added to some bundles: transport.modbus, transport.feed, webaudio...
but these shouldn't appear in the end user documentation since they are not add-ons.

Besides, the first two don't respect the convention that an addon should only have a . in its name if it's a sub-addon - the build script therefore assumes that a transport add-on exists and breaks.

We should find a way to properly exclude bundles with READMEs but are not addons from the docs.

cc @Confectrician

ghys added a commit that referenced this issue Mar 2, 2019
Put bundles which are not add-ons but now have READMEs on the ignore list.
Workaround for #159.

Signed-off-by: Yannick Schaus <[email protected]>
ghys added a commit that referenced this issue Mar 2, 2019
- Put bundles which are not add-ons but now have READMEs on the ignore list.
Workaround for #159.

- Temporarily ignore the jinja transformation until https://github.com/openhab/openhab2-addons/pull/5022 is merged

Signed-off-by: Yannick Schaus <[email protected]>
@Confectrician
Copy link
Contributor

Maybe we can do that within maven directly and exclude or move those.

But I will have to take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants