Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeNameCheck #352

Open
tmrobert8 opened this issue Apr 24, 2019 · 1 comment
Open

TypeNameCheck #352

tmrobert8 opened this issue Apr 24, 2019 · 1 comment

Comments

@tmrobert8
Copy link

Argh - this one is going to be painful for me. Looks like the type name check enforces a pattern '^[A-Z][a-zA-Z0-9]*$'.

Is there any chance we can get an underscore or dash included with that?

The reasoning - for sony products, their API differs depending on the API's version. Example: setPowerStatus v1.0 has a parameter of boolean and the getPowerStatus v1.0 returns a boolean. However, setPowerStatus v1.2 has a parameter of string and the getPowerStatus v1.2 returns a string.

To handle this in a reasonable manner - I have a "PowerStatus_1_0" class and a "PowerStatus_1_2" class.

That's one example out of about 50 classes named this way (I have one class that has 5 different variations depending on the version).

With out an underscore (or dash) - I'd have to renamed stuff to "PowerStatusOneZero" and "PowerStatusOneTwo" or something screwy like that. Using namespaces to differentiate will also be an even bigger issue (alot of overlap between versions so naming something like 'v1-5.xxx" would be hard to understand when the api would be spread over different namespaces).

@martinvw
Copy link
Member

Argh - this one is going to be painful for me. Looks like the type name check enforces a pattern '^[A-Z][a-zA-Z0-9]*$'.

Is it a fatal, I would be okay to add a specific ignore for this check for this bundle. I believe the configuration of ignores is in the repo somewhere... :-)

If you can't find it please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants