Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas Interactive SVG: Prevent image caching & Add id in config dialog #2881

Merged

Conversation

stefan-hoehn
Copy link
Contributor

prevent url caching in edit mode,
add svg element id to dialog title

Copy link

relativeci bot commented Nov 18, 2024

#2499 Bundle Size — 10.87MiB (~+0.01%).

ae526cf(current) vs 7c3d114 main#2496(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2499
     Baseline
#2496
Regression  Initial JS 1.91MiB(~+0.01%) 1.91MiB
No change  Initial CSS 577.31KiB 577.31KiB
Change  Cache Invalidation 17.55% 17.59%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2940 2940
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2499
     Baseline
#2496
Regression  JS 9.08MiB (~+0.01%) 9.08MiB
No change  CSS 864KiB 864KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch stefan-hoehn:interactive_svg_pre...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title Interactive SVG: prevent image caching, add id in config dialog Canvas Interactive SVG: Prevent image caching & Add id in config dialog Nov 18, 2024
@florian-h05 florian-h05 merged commit ed54bf6 into openhab:main Nov 18, 2024
8 checks passed
@florian-h05 florian-h05 deleted the interactive_svg_prevent_url_caching branch November 18, 2024 23:38
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 18, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants