Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete the backup files when uninstalling OH via a package manager #229

Open
nelsonaponte opened this issue Aug 30, 2024 · 1 comment

Comments

@nelsonaponte
Copy link

nelsonaponte commented Aug 30, 2024

When openHAB is managed by a package manager (apt, yum, dnf) and the user attempts to remove (uninstall) openHAB using the package manager, the folder under /var/lib/openhab/backups/ and all of its content should not be deleted.

If possible, a warning message saying "The backups folder under /var/lib/openhab/backups/ was not automatically deleted so you don't lose data if you want to reinstall openHAB. Please, delete it manually if required." should be displayed once the remove process ended successfully.

Reason

The purpose of this enhancement is to allow users to keep their backups when uninstalling openHAB, in case they need them in the future. Many users may not know or remember there are backups in the folder that they may need later and would forget to manually move them to another location.
Moreover, with #230, users may now know that there are backups automatically taken before any upgrade process.

@BClark09
Copy link
Member

BClark09 commented Sep 2, 2024

Agreed that the removal of openhab should not delete backups at least without prior warning. At the very least, the backup script should warn the user that a directory outside the package created directories should be used.

I'm away for a couple of weeks - but I'll look into the best options soon after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants