-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable scope and oh-context features to expression page #2313
Conversation
Signed-off-by: Justin Georgi <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks!
Just a few minor commens:
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: JustinGeorgi <[email protected]>
Great edits, thanks. Should be all set now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Markdownlint fails unrelated.
@openhab/documentation-maintainers Can you please merge?
I fixed the markdownlint in #2314 |
The new
oh-context
component includes several features important for advanced widget creation. This PR adds descriptions and some examples of these features to the widget variables and expression page.