Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable scope and oh-context features to expression page #2313

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

JustinGeorgi
Copy link
Contributor

The new oh-context component includes several features important for advanced widget creation. This PR adds descriptions and some examples of these features to the widget variables and expression page.

Copy link

netlify bot commented Jun 16, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 741090e
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/666efad32429a20008a61172
😎 Deploy Preview https://deploy-preview-2313--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!

Just a few minor commens:

ui/widget-expressions-variables.md Outdated Show resolved Hide resolved
ui/widget-expressions-variables.md Outdated Show resolved Hide resolved
ui/widget-expressions-variables.md Outdated Show resolved Hide resolved
ui/widget-expressions-variables.md Outdated Show resolved Hide resolved
Co-authored-by: Florian Hotze <[email protected]>
Signed-off-by: JustinGeorgi <[email protected]>
@JustinGeorgi
Copy link
Contributor Author

Great edits, thanks. Should be all set now.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Markdownlint fails unrelated.

@openhab/documentation-maintainers Can you please merge?

@jimtng
Copy link
Contributor

jimtng commented Jun 17, 2024

I fixed the markdownlint in #2314

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone Jun 26, 2024
@stefan-hoehn stefan-hoehn merged commit 2cda6b8 into openhab:main Jun 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants