add latest docu of blockly features of M2 #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Stefan Höhn <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/129 |
Signed-off-by: Stefan Höhn <[email protected]>
florian-h05
reviewed
May 27, 2024
There was a problem hiding this comment.
In general LGTM, please have a look at my comments.
Please do not make the suggested changes locally and then push a commit, just go to the code tab, add the suggestions "to batch" and then "commit and sign-off batch" (green button). This automatically resolves the suggestions and eases review for us both 👍
Afterwards address the rest locally and push a commit please.
|
|
||
| rules[“id”] gives you the rule object for the given id, which supports the [trigger method](https://openhab.github.io/openhab-jruby/main/OpenHAB/Core/Rules/Rule.html#trigger-instance_method) (aliased as run). | ||
|
|
||
| > rules["scene_id"].run |
There was a problem hiding this comment.
Please use code fences and set ruby or rb as language.
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: Florian Hotze <[email protected]> Signed-off-by: stefan-hoehn <[email protected]>
Signed-off-by: Stefan Höhn <[email protected]>
florian-h05
reviewed
May 27, 2024
|
|
||
| ```ruby | ||
| rules["scene_id"].run | ||
| `` |
There was a problem hiding this comment.
There should be three of these signs.
Signed-off-by: Stefan Höhn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing documentation for the following new blockly features
and many more small corrections