Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[knx] Readme: Troubleshooting, Logger, kBerry #17797

Merged
merged 2 commits into from
Nov 23, 2024
Merged

[knx] Readme: Troubleshooting, Logger, kBerry #17797

merged 2 commits into from
Nov 23, 2024

Conversation

holgerfriedrich
Copy link
Member

No description provided.

jlaur
jlaur requested changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor comments from proof-reading.

bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.knx/README.md Outdated Show resolved Hide resolved
@holgerfriedrich
review
d5f3860 
Signed-off-by: Holger Friedrich <[email protected]>
jlaur
jlaur approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich
Copy link
Member Author

Thanks! Just a few minor comments from proof-reading.

Thanks for catching all this, @jlaur. Readme file is updated by now.

@jlaur jlaur merged commit 8bc8961 into openhab:main Nov 23, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.3 milestone Nov 23, 2024
@holgerfriedrich holgerfriedrich deleted the pr-knx-docs branch November 23, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerfriedrich @jlaur