Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JRuby examples in READMEs #16948

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Add JRuby examples in READMEs #16948

merged 7 commits into from
Jun 28, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jun 28, 2024

No description provided.

@jimtng
Add JRuby examples in README
328e587 
Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng requested review from jlaur, mvalla, ecdye, J-N-K, gerrieg and a team as code owners June 28, 2024 12:26
@jimtng
Copy link
Contributor Author

jimtng commented Jun 28, 2024

@ccutrer I'd appreciate your review on this thanks!

@jlaur
Copy link
Contributor

jlaur commented Jun 28, 2024

@jimtng - many thanks for the JRuby examples. It's been on my mind learning JRuby a bit to provide example for Energi Data Service. Then gradually lowered my ambitions and considered asking you for help instead. So you read my mind and beat me. 😄 Would it be possible for you to also provide an example for this new section?

https://next.openhab.org/addons/bindings/energidataservice/#javascript

@jimtng
Copy link
Contributor Author

jimtng commented Jun 28, 2024

Would it be possible for you to also provide an example for this new section?

https://next.openhab.org/addons/bindings/energidataservice/#javascript

Ha! Thanks for that! I only searched for :: tab DSL hence why I missed that section because it doesn't have a DSL counterpart!

I'll add a JRuby example for that shortly!

ccutrer
ccutrer reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the title to "Add JRuby examples in READMEs"? seeing the email notification, I thought this was the JRuby add-on readme, not readmes for other addons that have examples

bundles/org.openhab.binding.energidataservice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.energidataservice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.homematic/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.omnilink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.omnilink/README.md Outdated Show resolved Hide resolved
@jimtng jimtng changed the title Add JRuby examples in README Add JRuby examples in READMEs Jun 28, 2024
@jimtng
s/energi/eds/
0af437a 
Signed-off-by: Jimmy Tanagra <[email protected]>
jlaur
jlaur approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As binding maintainer, LGTM for Energi Data Service and Value-Added Tax. Many thanks!

As maintainer, LGTM for others as well, but counting on @ccutrer's review for the Ruby code itself. 😉 Thanks for the review.

@jlaur
Copy link
Contributor

jlaur commented Jun 28, 2024

I only searched for :: tab DSL hence why I missed that section because it doesn't have a DSL counterpart!

Indeed, I got too rusty in DSL to create a working implementation for this.🙁

@jlaur jlaur merged commit ae34f95 into openhab:main Jun 28, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.2 milestone Jun 28, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 29, 2024
@jimtng @psmedley
Add JRuby examples in READMEs (openhab#16948)
b748102 
Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng deleted the jruby-examples branch June 29, 2024 13:44
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@jimtng @pgfeller
Add JRuby examples in READMEs (openhab#16948)
f895118 
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jimtng @joni1993
Add JRuby examples in READMEs (openhab#16948)
b178997 
Signed-off-by: Jimmy Tanagra <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@jimtng @matchews
Add JRuby examples in READMEs (openhab#16948)
b0d5801 
Signed-off-by: Jimmy Tanagra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@ccutrer ccutrer ccutrer approved these changes

@mvalla mvalla Awaiting requested review from mvalla mvalla is a code owner

@ecdye ecdye Awaiting requested review from ecdye ecdye is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jimtng @jlaur @ccutrer