Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustpotterks] Upgrade to version 2 #14615

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[rustpotterks] Upgrade to version 2 #14615

merged 3 commits into from
Mar 21, 2023

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Mar 15, 2023

Use new library version, which seems to perform better.

Note: Keyword files from the previous version are not compatibles.

Signed-off-by: Miguel Álvarez <[email protected]>
@jlaur jlaur changed the title [rustpotter] Use version 2 [rustpotterks] Upgrade to version 2 Mar 15, 2023
@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible labels Mar 20, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only minor comments from my side.

bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
Signed-off-by: Miguel Álvarez <[email protected]>
@GiviMAD GiviMAD requested a review from jlaur March 21, 2023 20:23
Signed-off-by: Miguel Álvarez <[email protected]>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit aa3229a into openhab:main Mar 21, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 21, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* [rustpotter] Use version 2

Signed-off-by: Miguel Álvarez <[email protected]>
GiviMAD added a commit to GiviMAD/openhab-addons that referenced this pull request Mar 26, 2023
* [rustpotter] Use version 2

Signed-off-by: Miguel Álvarez <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* [rustpotter] Use version 2

Signed-off-by: Miguel Álvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants