Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velux] Update documentation #14478

Merged
merged 2 commits into from
Mar 7, 2023
Merged

[velux] Update documentation #14478

merged 2 commits into from
Mar 7, 2023

Conversation

andrewfg
Copy link
Contributor

Resolves #14404

As stated in Issue #14404 a user found the binding documentation concerning the inverted parameter to be confusing.

So this PR adds further information to the readme file to better explain the meaning of the inverted parameter.

Note: this PR includes all the changes from #14371 in order to (hopefully) avoid a merge conflict.

Signed-off-by: Andrew Fiddian-Green [email protected]

Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg added documentation awaiting other PR Depends on another PR labels Feb 22, 2023
@andrewfg andrewfg self-assigned this Feb 22, 2023
Copy link
Contributor

@jirikraus jirikraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewfg this addresses my confusion and #14404 . As the table is inconsistent with the provided Bathroom_Roof_Window_Position example I am suggestion some updates to that.

bundles/org.openhab.binding.velux/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.velux/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.velux/README.md Outdated Show resolved Hide resolved
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg requested a review from a team February 27, 2023 15:23
@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Feb 28, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jlaur jlaur merged commit c9d5784 into openhab:main Mar 7, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 7, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* [velux] update documentation

Signed-off-by: Andrew Fiddian-Green <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* [velux] update documentation

Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg deleted the velux-doc2 branch August 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[velux] inverting position has no effect
3 participants