Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ili2db's exportMetaConfig operation #121

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Nov 20, 2024

Also, replace parsing the ili2db settings from the ili2db's metadata tables by parsing the metaConfig ini file produced by the ili2db's exportMetaConfig command.

…2db v5.2.0) to get all parameters used in the schema import operation exported to a single file
@gacarrillor gacarrillor marked this pull request as draft November 21, 2024 00:19
…pendency (package removed in Python 3.12, and deprecated in Python 3.10)
…ameters from an exported metaConfig .ini file in ilitoppingmaker
@gacarrillor gacarrillor marked this pull request as ready for review November 26, 2024 05:07
@gacarrillor
Copy link
Collaborator Author

@signedav, would it be OK for you to upgrade autoflake?
See c1216a4 for details.

@gacarrillor
Copy link
Collaborator Author

@signedav, should we get rid of parse_parameters_from_db

def parse_parameters_from_db(self, db_connector):
?

@signedav
Copy link
Member

signedav commented Nov 26, 2024

@signedav, should we get rid of parse_parameters_from_db

yes

@gacarrillor
Copy link
Collaborator Author

@signedav, should we get rid of parse_parameters_from_db

yes

Done.

@gacarrillor gacarrillor requested a review from signedav November 26, 2024 22:36
Copy link
Member

@signedav signedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@signedav signedav merged commit 6ab186b into main Nov 27, 2024
5 checks passed
@signedav signedav deleted the add_exportmetaconfig_operation branch November 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants