Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is a Storey? #107

Open
PeterParslow opened this issue Mar 2, 2020 · 9 comments
Open

What is a Storey? #107

PeterParslow opened this issue Mar 2, 2020 · 9 comments
Assignees

Comments

@PeterParslow
Copy link

PeterParslow commented Mar 2, 2020

A question more than an "issue", at least at this stage. It has arisen as I try to relate Apple's IMDF to CityGML.

As "a horizontal section of a building", I was expecting a Storey feature to be a subtype of construction. This understanding is supported by two current facts of the model: Storeys don't relate directly to Address, but can be bound by surfaces.

However, it is not supported by Storey being a subtype of AbstractBuildingSubdivision, an AbstractLogicalSpace - that places it semantically as a 'logical space' rather than a physical one ('construction').

Assuming that is deliberate, what is meant by CityGML Storey?

I admit I missed this definition by only dipping into the modelling sub-group discussion.

This is partly related to #8 , and may have resulted from resolving that issue - with BuildingParts no longer required to touch the ground, they become a way of modelling (physical) storey constructions.

@3DXScape
Copy link
Contributor

This issue appears several times including #119 Nobu_E_5. I think it indicates that some more explanation would help.

@3DXScape
Copy link
Contributor

3DXScape commented Jul 9, 2020

A storey is a logical concept and the proposed resolution is to improve definition in Specification enhance the explanation in the User Guide, especially to distinguish building parts and storeys.

@cmheazel
Copy link
Contributor

Improving the definition in the specification is an update to the UML model.
Who will write a section for the User Guide?

@TatjanaKutzner
Copy link
Contributor

The definition in the UML model has been improved. It says now: "A Storey is typically a horizontal section of a Building. Storeys are not always defined according to the building structure, but can also be defined according to logical considerations."

@TatjanaKutzner
Copy link
Contributor

I checked the latest PDF, the PDF still contains the old definition, not the improved one.

@cmheazel
Copy link
Contributor

cmheazel commented Sep 1, 2020

@TatjanaKutzner Naturally.
The PDF is generated every evening. Changes made today will not show up until tomorrow.
As for changes to the UML. They have to be exported from the UML model, then hand edited into the AsciiDoc documents. At that point they become available for inclusion in the PDF. Due to the level of effort involved, this is only done once all pending changes have been applied to the UML model.

@TatjanaKutzner
Copy link
Contributor

Ok, I understand. Thomas asked me to check whether all changes are reflected in the PDF already. Since I did the changes to the UML model early August already, I was wondering that they are still not in the PDF.

@cmheazel
Copy link
Contributor

cmheazel commented Sep 1, 2020

@TatjanaKutzner You should find that the figures have been updated to the early August version. However, there were still potential changes to the text. So I deferred updates to the data dictionary until those changes had been made. Once we are certain that we have a final version of the UML (as near as we can tell), then I'll invest the time into updating the data dictionary.

@cmheazel
Copy link
Contributor

cmheazel commented Sep 2, 2020

We may still want to add related content to the Users Guide. So let's leave this issue open for now, but remove all but the "Guide" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants