-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is a Storey? #107
Comments
This issue appears several times including #119 Nobu_E_5. I think it indicates that some more explanation would help. |
A storey is a logical concept and the proposed resolution is to improve definition in Specification enhance the explanation in the User Guide, especially to distinguish building parts and storeys. |
Improving the definition in the specification is an update to the UML model. |
The definition in the UML model has been improved. It says now: "A Storey is typically a horizontal section of a Building. Storeys are not always defined according to the building structure, but can also be defined according to logical considerations." |
I checked the latest PDF, the PDF still contains the old definition, not the improved one. |
@TatjanaKutzner Naturally. |
Ok, I understand. Thomas asked me to check whether all changes are reflected in the PDF already. Since I did the changes to the UML model early August already, I was wondering that they are still not in the PDF. |
@TatjanaKutzner You should find that the figures have been updated to the early August version. However, there were still potential changes to the text. So I deferred updates to the data dictionary until those changes had been made. Once we are certain that we have a final version of the UML (as near as we can tell), then I'll invest the time into updating the data dictionary. |
We may still want to add related content to the Users Guide. So let's leave this issue open for now, but remove all but the "Guide" label. |
A question more than an "issue", at least at this stage. It has arisen as I try to relate Apple's IMDF to CityGML.
As "a horizontal section of a building", I was expecting a Storey feature to be a subtype of construction. This understanding is supported by two current facts of the model: Storeys don't relate directly to Address, but can be bound by surfaces.
However, it is not supported by Storey being a subtype of AbstractBuildingSubdivision, an AbstractLogicalSpace - that places it semantically as a 'logical space' rather than a physical one ('construction').
Assuming that is deliberate, what is meant by CityGML Storey?
I admit I missed this definition by only dipping into the modelling sub-group discussion.
This is partly related to #8 , and may have resulted from resolving that issue - with BuildingParts no longer required to touch the ground, they become a way of modelling (physical) storey constructions.
The text was updated successfully, but these errors were encountered: