Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions rely on OF submodule which does not necessarily track HEAD #412

Open
artificiel opened this issue Aug 28, 2023 · 1 comment

Comments

@artificiel
Copy link
Contributor

The PG build instructions are based on an OF download, but the submodule there is tied to a specific PG commit. Which might make sense in terms of integration on the OF side, but not on the PG dev side.

The instruction in PG repo should produce a HEAD-based build.

Sister issue to untangle too: openframeworks/openFrameworks#7609

@dimitre
Copy link
Member

dimitre commented Nov 22, 2023

Now 0.12.0 is out I think it is a good time to reavail the need of using projectGenerator (and maybe apothecary) as submodules.
They can be cloned on demand via some script.
This way we always point to head, have simpler PRs for OF without changes in submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants