Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG_MODE_CREATE / PG_MODE_UPDATE issues #353

Open
dimitre opened this issue Apr 19, 2023 · 2 comments
Open

PG_MODE_CREATE / PG_MODE_UPDATE issues #353

dimitre opened this issue Apr 19, 2023 · 2 comments

Comments

@dimitre
Copy link
Member

dimitre commented Apr 19, 2023

Due to some incorrect path parsing PG_MODE_CREATE was always invoked
and now PG_MODE_UPDATE is being correctly invoked but doesn't create projects
we should revisit this functionality, not only code-wise but idea-wise.
Which folder should be checked for the testing of CREATE/UPDATE. or even if we are going to differentiate both.

@ofTheo
Copy link
Member

ofTheo commented Apr 19, 2023

yeah I think the way the frontend worked updating a project just recreates it based on addons.make and any of the config.make extra paths.

I think as long as the new code does this that is fine but if it now doesn't recreate the project files we probably will want to keep the old behavior.

@dimitre
Copy link
Member Author

dimitre commented Apr 19, 2023

I was hardcoding PG_MODE_CREATE until yesterday but it resulted in issues with recursive scripts.
so I wonder if this PG_MODE is relevant at all. will read more code later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants