feat: 995 - support of the new "product type" filter for "get product" #1004
+117
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `product_type_filter.dart`: Filter on product type for API get product queries. Impacted files * `api_not_food_get_product_test.dart`: now testing only in v3 with all product type filters * `old_product_result.dart`: deprecated class `OldProductResult` * `open_food_api_client.dart`: deprecated method `getOldProduct` * `openfoodfacts.dart`: export new file `product_type_filter.dart` * `product_query_configurations.dart`: "product_type_filter" as new optional "get product" parameter; minor refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
- Coverage 76.34% 75.75% -0.60%
==========================================
Files 239 252 +13
Lines 8494 9436 +942
==========================================
+ Hits 6485 7148 +663
- Misses 2009 2288 +279 ☔ View full report in Codecov by Sentry. |
g123k
reviewed
Nov 29, 2024
| ProductTypeFilter(final ProductType productType) | ||
| : offTag = productType.offTag; | ||
|
|
||
| static const all = ProductTypeFilter._('all'); |
There was a problem hiding this comment.
I think you've missed the type here
There was a problem hiding this comment.
Indeed. Strange the lint check didn't send a warning.
I'll fix that.
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
New file:
product_type_filter.dart: Filter on product type for API get product queries.Impacted files
api_not_food_get_product_test.dart: now testing only in v3 with all product type filtersold_product_result.dart: deprecated classOldProductResultopen_food_api_client.dart: deprecated methodgetOldProductopenfoodfacts.dart: export new fileproduct_type_filter.dartproduct_query_configurations.dart: "product_type_filter" as new optional "get product" parameter; minor refactoring