Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleaning of candidate names #32

Open
warwickmm opened this issue Jun 17, 2021 · 0 comments
Open

Improve cleaning of candidate names #32

warwickmm opened this issue Jun 17, 2021 · 0 comments

Comments

@warwickmm
Copy link
Member

In the Tickets class, we clean candidate names by replacing bad characters:

BAD_CHARS = {
'.': '',
',': '',
':': '',
'"': '', # only for hanging quote marks
'-': ' ',# since all quote sections cut first
"'": ' ',
'&': 'AND',
'“': '',
'”': ''
}

This seems a bit aggressive, as it's not uncommon for names to contain ' and - (e.g., Shannon O'Brien, Cindy Hyde-Smith).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant