MFE localization issues

[ehuthmacher]

• [editors] Localization issues - strings not marked for translation frontend-app-authoring#1237
• [frontend-app-communications] Localization issues frontend-app-communications#148

[ehuthmacher]

Please track progress in the following PRs:

1. [editors] Localization issues - strings not marked for translation frontend-app-authoring#1237
2. [frontend-app-communications] Localization issues frontend-app-communications#148

[arbrandes]

The communications MFE will be ready for Quince, but not frontend-lib-content-components.

[OmarIthawi]

@arbrandes what was the problem with frontend-lib-content-components? It should be ready as well unless we missed anything in the process.

[arbrandes]

@OmarIthawi, this is the issue: openedx/frontend-app-authoring#1237. I'm not aware of any changes that were made in response. Have you tested it recently?

[OmarIthawi]

I've commented on the openedx/frontend-app-authoring#1237 with suggested fixes for the MFE itself.

However, I realize that frontend-app-communications doesn't pull the frontend-lib-content-components which needs to be added to the Makefile, like paragon.

The problem is that we have many small repositories that needs to be pulled:

• frontend-component-header (pulled)
• frontend-component-footer (pulled)
• paragon (pulled)
• frontend-lib-content-components
• frontend-lib-special-exams (not pulled, but some repos like Learning MFE need it)
• frontend-platform (it has two messages)
• frontend-component-cookie-policy-banner

Therefore, for example, the communications pull command should become:

atlas pull \
	translations/frontend-component-header/src/i18n/messages:frontend-component-header  \
	translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
	translations/paragon/src/i18n/messages:paragon \
	translations/frontend-lib-content-components/src/i18n/messages:frontend-lib-content-components \
	translations/frontend-platform/src/i18n/messages:frontend-platform \
	translations/frontend-component-cookie-policy-banner/src/i18n/messages:frontend-component-cookie-policy-banner \
	translations/frontend-app-communications/src/i18n/messages:frontend-app-communications

We currently pull only three of the list above. We can loop over the MFEs and add the rest of the list.
It feels a bit too verbose to pull each one individually, so I was thinking of combining the following resources into a single frontend-common Transifex resource:

• paragon
• frontend-lib-content-components
• frontend-lib-special-exams
• frontend-platform

This needs a script in the openedx-translations extract-translation-source-files.yml workflow.

Which reduces the communications MFE pull command to the following:

atlas pull \
	translations/frontend-component-header/src/i18n/messages:frontend-component-header  \
	translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
	translations/frontend-common/src/i18n/messages:frontend-common \
	translations/frontend-app-communications/src/i18n/messages:frontend-app-communications

Notice I'm keeping the header and footer as separate because they're likely to be replaced by the different operators.

What do you think @brian-smith-tcril @arbrandes?

[brian-smith-tcril]

It feels a bit too verbose to pull each one individually

I don't think it being verbose is necessarily a problem. It's very clear what is being pulled, and it ensures we're only pulling exactly what is needed for any given MFE.

The only part that feels a little odd is frontend-platform which only has 2 messages, but even that doesn't feel particularly bad.

[OmarIthawi]

It feels a bit too verbose to pull each one individually

I don't think it being verbose is necessarily a problem. It's very clear what is being pulled, and it ensures we're only pulling exactly what is needed for any given MFE.

The only part that feels a little odd is frontend-platform which only has 2 messages, but even that doesn't feel particularly bad.

We may be able to skip frontend-platform since their messages are duplicated in frontend-lib-content-component. Nevertheless, thanks for the input. I'll add it to the list of common MFE tasks.

[OmarIthawi]

I'll add those lines communications MFE to test and then we'll apply for others.

atlas pull \
	translations/frontend-component-header/src/i18n/messages:frontend-component-header  \
	translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
	translations/paragon/src/i18n/messages:paragon \
	translations/frontend-lib-content-components/src/i18n/messages:frontend-lib-content-components \
	translations/frontend-platform/src/i18n/messages:frontend-platform \
	translations/frontend-component-cookie-policy-banner/src/i18n/messages:frontend-component-cookie-policy-banner \
	translations/frontend-app-communications/src/i18n/messages:frontend-app-communications