-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a from-GitHub
Jira label to Jira issues. #279
#281
Conversation
cab6677
to
7ab0926
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 90.00% 90.04% +0.04%
==========================================
Files 38 38
Lines 2840 2853 +13
Branches 393 398 +5
==========================================
+ Hits 2556 2569 +13
Misses 259 259
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question that might suggest a change in the docs but nothing else.
docs/details.rst
Outdated
@@ -128,3 +128,5 @@ bot will create a Jira issue in the Jira server with the "xyz" nickname. | |||
|
|||
Each Jira server can specify a mapping of repos to other Jira details such as | |||
the Jira project for the issue, and the issue type to create. | |||
|
|||
Jira issues created this way will have a "from GitHub" Jira label applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this label need to be created on the JIRA side before it can be applied? Or will it automatically get created when you try to apply it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be made first, but testing that turned up a different problem, now fixed: no spaces allowed in Jira labels.
7ab0926
to
cd79e95
Compare
from GitHub
Jira label to Jira issues. #279from-GitHub
Jira label to Jira issues. #279
No description provided.