Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a from-GitHub Jira label to Jira issues. #279 #281

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Nov 20, 2023

No description provided.

@nedbat nedbat requested a review from feanil November 20, 2023 16:45
@nedbat nedbat force-pushed the nedbat/from-github-label-279 branch from cab6677 to 7ab0926 Compare November 20, 2023 16:45
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f38cd66) 90.00% compared to head (ba1a815) 90.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   90.00%   90.04%   +0.04%     
==========================================
  Files          38       38              
  Lines        2840     2853      +13     
  Branches      393      398       +5     
==========================================
+ Hits         2556     2569      +13     
  Misses        259      259              
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question that might suggest a change in the docs but nothing else.

docs/details.rst Outdated
@@ -128,3 +128,5 @@ bot will create a Jira issue in the Jira server with the "xyz" nickname.

Each Jira server can specify a mapping of repos to other Jira details such as
the Jira project for the issue, and the issue type to create.

Jira issues created this way will have a "from GitHub" Jira label applied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this label need to be created on the JIRA side before it can be applied? Or will it automatically get created when you try to apply it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to be made first, but testing that turned up a different problem, now fixed: no spaces allowed in Jira labels.

@nedbat nedbat force-pushed the nedbat/from-github-label-279 branch from 7ab0926 to cd79e95 Compare November 27, 2023 16:24
@nedbat nedbat changed the title feat: add a from GitHub Jira label to Jira issues. #279 feat: add a from-GitHub Jira label to Jira issues. #279 Nov 27, 2023
@nedbat
Copy link
Contributor Author

nedbat commented Nov 27, 2023

It works:
image

@nedbat nedbat merged commit 3ee0182 into master Nov 27, 2023
5 checks passed
@nedbat nedbat deleted the nedbat/from-github-label-279 branch November 27, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants