Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot shouldn't say "we don't accept contributions" when someone closes a PR #273

Closed
nedbat opened this issue Oct 31, 2023 · 1 comment
Closed

Comments

@nedbat
Copy link
Contributor

nedbat commented Oct 31, 2023

See what happened here: edx/dbt-schema-builder#54

A PR was closed. The author no longer works for edX, so was considered external. The bot added a comment (twice?) saying that contributions aren't accepted. This is just extra noise, the contribution was being cancelled already.

@nedbat
Copy link
Contributor Author

nedbat commented Nov 1, 2023

BTW, it comments twice because the "Close with comment" button causes two events to fire (comment created and pull request closed). They are both sent to the webhook at the same time, so two requests are handled, and each sees the pull request with no comment on it, so both add a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant