Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling #270

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Improved exception handling #270

merged 3 commits into from
Oct 23, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Oct 19, 2023

Also, a little bit more ad-hoc exception testing.

@nedbat nedbat force-pushed the nedbat/exception-handling branch from b5eaf4f to 7bd580a Compare October 19, 2023 21:09
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (96fa644) 89.42% compared to head (10dd875) 89.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   89.42%   89.35%   -0.07%     
==========================================
  Files          38       38              
  Lines        2789     2810      +21     
  Branches      384      392       +8     
==========================================
+ Hits         2494     2511      +17     
- Misses        266      269       +3     
- Partials       29       30       +1     
Files Coverage Δ
tests/test_pull_request_opened.py 100.00% <100.00%> (ø)
openedx_webhooks/tasks/pr_tracking.py 94.47% <80.00%> (-1.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nedbat nedbat requested a review from feanil October 19, 2023 21:09
@nedbat nedbat force-pushed the nedbat/exception-handling branch from 7bd580a to 10dd875 Compare October 19, 2023 21:46
@nedbat nedbat merged commit 847ec3b into master Oct 23, 2023
2 of 4 checks passed
@nedbat nedbat deleted the nedbat/exception-handling branch October 23, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants