Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on 3.11, and upgrade one package at a time. #269

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Oct 17, 2023

No description provided.

Ned Batchelder added 3 commits October 17, 2023 15:58
@nedbat nedbat requested a review from feanil October 17, 2023 21:06
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b906a4e) 89.42% compared to head (7bd3d66) 89.42%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #269    +/-   ##
========================================
  Coverage   89.42%   89.42%            
========================================
  Files          38       38            
  Lines        2789     2789            
  Branches      282      384   +102     
========================================
  Hits         2494     2494            
  Misses        266      266            
  Partials       29       29            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this re-compiles but does not do any upgrades yet? Is the plan to upgrade individual things in this PR or in follow-ups?

@nedbat
Copy link
Contributor Author

nedbat commented Oct 18, 2023

I should have explained: I added the typing dependencies, then ran make upgrade-package package=types-PyYAML to only add the newly added packages. So the generic upgrades haven't happened yet. I would like to wait on the broad upgrades until we can review their changelogs.

@nedbat nedbat merged commit 96fa644 into master Oct 18, 2023
4 checks passed
@nedbat nedbat deleted the nedbat/progress branch October 18, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants