Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive-by clean-ups #264

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Drive-by clean-ups #264

merged 4 commits into from
Sep 22, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Sep 22, 2023

  • removed Jira webhook code, since we don't expect to have Jira-initiated actions.
  • pylint violations
  • moved tests into the tests/ directory and consolidated to match the .py files
  • move an if into a match/case

@nedbat nedbat requested a review from feanil September 22, 2023 18:35
We don't plan to have Jira actions trigger bot activity.
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 97.61% and project coverage change: +3.34% 🎉

Comparison is base (bce4b0f) 80.36% compared to head (26d3b5c) 83.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   80.36%   83.71%   +3.34%     
==========================================
  Files          41       38       -3     
  Lines        3082     2916     -166     
  Branches      328      306      -22     
==========================================
- Hits         2477     2441      -36     
+ Misses        572      442     -130     
  Partials       33       33              
Files Changed Coverage Δ
openedx_webhooks/__init__.py 74.60% <ø> (-0.79%) ⬇️
openedx_webhooks/github_views.py 27.52% <0.00%> (+0.25%) ⬆️
openedx_webhooks/tasks/__init__.py 51.61% <ø> (-4.27%) ⬇️
tests/test_utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nedbat nedbat merged commit dd0d10d into master Sep 22, 2023
@nedbat nedbat deleted the nedbat/clean-ups branch September 22, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants