Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added SSO switch-on check #547

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Dec 5, 2024

On Logistration Bottom View did not check if SSO was enabled or not. Because of this, the ‘Sign in with SSO’ button was displayed in the start view even with SSO disabled:

@rnr rnr requested a review from IvanStepanok December 5, 2024 14:50
@volodymyr-chekyrta volodymyr-chekyrta merged commit 0f16019 into openedx:develop Dec 5, 2024
7 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@55f601c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             develop   #547   +/-   ##
========================================
  Coverage           ?      0           
========================================
  Files              ?      0           
  Lines              ?      0           
  Branches           ?      0           
========================================
  Hits               ?      0           
  Misses             ?      0           
  Partials           ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnr rnr deleted the quickfix/sso-button-config branch December 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants