perf: instance cache and select-related for license serialization #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For large numbers of licenses (> 1000), this change gets us from 100s of SQL queries down to around 10 for each page of admin-license-list results.
@cached_property
to net_days_until_expiration on the agreement model.MinimalCustomerAgreementSerializer.net_days_until_expiration
._get_subscription_plan()
- this eliminated 4 duplicate queries.Testing considerations
already been performed.
Post-review
Squash commits into discrete sets of changes