Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI slot component with the basic config #662

Closed
wants to merge 3 commits into from

Conversation

johnvente
Copy link
Contributor

Description:

This PR the basic PluggableComponent which will allow to reuse it where we need it and an util called contextFactory will help us to have a context provider that we will use thro a reducer to share data between components or even PluggableComponent if you rather. The main idea is to have those to be reusable in any MFE that way we don't need to setup them.

This PR depends on this one: openedx/frontend-build#518

How to test it

  1. Install dependencies
nvm use && npm install
  1. Start the frontend-build
npm start
  1. You should be able to see this following plugin which is only for test purpuses:
Screen Shot 2024-03-13 at 1 32 01 PM

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@openedx-webhooks
Copy link

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 13, 2024
@johnvente johnvente force-pushed the jv/feat-ui-slot-config branch from c6c934f to b72e103 Compare March 13, 2024 20:54
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 88.78505% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.98%. Comparing base (441800f) to head (b72e103).

Files Patch % Lines
src/react/utils/contextFactory/withProvider.jsx 33.33% 4 Missing ⚠️
src/react/PluggableComponent/MultiplePlugins.jsx 92.10% 3 Missing ⚠️
src/react/PluggableComponent/index.jsx 91.89% 3 Missing ⚠️
src/react/utils/contextFactory/index.js 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   83.50%   83.98%   +0.47%     
==========================================
  Files          40       45       +5     
  Lines        1073     1180     +107     
  Branches      197      218      +21     
==========================================
+ Hits          896      991      +95     
- Misses        165      177      +12     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnvente johnvente closed this Mar 13, 2024
@openedx-webhooks
Copy link

@johnvente Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants