Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fa, fa-ir locales in mockMessages #612

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

awais-ansari
Copy link
Contributor

Description:
Locale missing console warnings for fa, fa-ir are raised while running test cases. Same locales warnings are raised in many MFEs. Such as Discussions, Course-authoring.
Screenshot 2023-12-01 at 10 16 36 PM
Screenshot 2023-12-01 at 10 53 10 PM

Merge checklist:

  • [ ✅] Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • [ ✅] Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • [✅ ] Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee6e79b) 83.22% compared to head (52b0f15) 83.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          893      893           
  Misses        168      168           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 3a93d60 into master Dec 6, 2023
7 checks passed
@awais-ansari awais-ansari deleted the aansari/missing-locale branch December 6, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants