Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demoted react-intl to v5 #592

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

BilalQamar95
Copy link
Contributor

Description:

Demoted react-intl to v5 in light of breaking tests for consumers.

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@BilalQamar95 BilalQamar95 self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (755e890) 0.00% compared to head (3833394) 83.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #592       +/-   ##
===========================================
+ Coverage        0   83.22%   +83.22%     
===========================================
  Files           0       40       +40     
  Lines           0     1073     +1073     
  Branches        0      197      +197     
===========================================
+ Hits            0      893      +893     
- Misses          0      168      +168     
- Partials        0       12       +12     

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 merged commit 0a9dcc0 into master Oct 24, 2023
6 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/demoted-react-intl-version branch October 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants